-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(): rm isClick
artifacts leftovers from #9434
#9478
Conversation
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should merge this
src/canvas/Canvas.ts
Outdated
const objects = | ||
collectedObjects.length > 1 | ||
? collectedObjects.filter((object) => !object.onSelect({ e })).reverse() | ||
: collectedObjects; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we call onSelect in this case (length === 1)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it gets solved by setActiveObject shortly below, while the object.length > 1 uses an collection.add method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
This requires a comment
d569461
to
5e15789
Compare
5c7cf14
to
ce62854
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to merge
isClick
artifactsisClick
artifacts leftovers from #9434
Motivation
Description
I missed
isClick
props in #9434Changes
isClick
props from events that are not mouseuprmisClick
check insidehandleSelection
because it runs inside a condition that checks that already in mouse upGist
In Action